Hi,

Unfortunately the patches still cause seg-fault at QAT and SW PMDs.

- for qat it fails at rte_security_ops->session_size_get not implemented.
- for sw pmds the queue pair's session private mempools are not set.

Regards,
Fan

-----Original Message-----
From: Akhil Goyal <redacted>
Sent: Thursday, October 14, 2021 12:48 PM
To: Akhil Goyal <redacted>; dev@dpdk.org
Cc: thomas@monjalon.net; david.marchand@redhat.com;
hemant.agrawal@nxp.com; Anoob Joseph [off-list ref]; De Lara
Guarch, Pablo [off-list ref]; Trahe, Fiona
[off-list ref]; Doherty, Declan [off-list ref];
matan@nvidia.com; g.singh@nxp.com; Zhang, Roy Fan
[off-list ref]; jianjay.zhou@huawei.com;
asomalap@amd.com; ruifeng.wang@arm.com; Ananyev, Konstantin
[off-list ref]; Nicolau, Radu [off-list ref];
ajit.khaparde@broadcom.com; Nagadheeraj Rottela
[off-list ref]; Ankur Dwivedi [off-list ref];
Power, Ciara [off-list ref]; Wang, Haiyue
[off-list ref]; jiawenwu@trustnetic.com;
jianwang@trustnetic.com
Subject: RE: [PATCH v2 0/7] crypto/security session framework rework

quoted

Subject: [PATCH v2 0/7] crypto/security session framework rework

As discussed in last release deprecation notice,
crypto and security session framework are reworked
to reduce the need of two mempool objects and
remove the requirement to expose the rte_security_session
and rte_cryptodev_sym_session structures.
Design methodology is explained in the patch description.

Similar work will need to be done for asymmetric sessions
as well. Asymmetric session need another rework and is
postponed to next release. Since it is still in experimental
stage, we can modify the APIs in next release as well.

The patches are compilable with all affected PMDs
and tested with dpdk-test and ipsec-secgw app on CN9k platform.

Changes in v2:
- Added new parameter iova in PMD session configure APIs for
  session priv pointer to be used in QAT/CNXK/etc PMDs.
- Hide rte_cryptodev_sym_session and rte_security_session structs.
- Added compilation workaround for net PMDs(ixgbe/txgbe)
  for inline ipsec.
  Patches with actual fix is beynd the scope of this patchset.
- Added inline APIs to access the opaque data and fast metadata.
- Remove commented code.
TODO
- Release notes/deprecation notice removal.
- Documentation updates.
- Asym APIs - postponed for next release.

Akhil Goyal (7):
  security: rework session framework
  security: hide security session struct
  net/cnxk: rework security session framework
  security: pass session iova in PMD sess create
  cryptodev: rework session framework
  cryptodev: hide sym session structure
  cryptodev: pass session iova in configure session

The series is rebased over following to avoid merge conflicts
http://patches.dpdk.org/user/todo/dpdk/?series=19519
http://patches.dpdk.org/user/todo/dpdk/?series=19467
http://patches.dpdk.org/user/todo/dpdk/?series=19551

(HEAD -> next-crypto) cryptodev: pass session iova in configure session
cryptodev: hide sym session structure
cryptodev: rework session framework
security: pass session iova in PMD sess create
net/cnxk: rework security session framework
security: hide security session struct
security: rework session framework
cryptodev: move device specific structures
cryptodev: update fast path APIs to use new flat array
cryptodev: move inline APIs into separate structure
cryptodev: allocate max space for internal qp array
cryptodev: separate out internal structures
security: add reserved bitfields
security: hide internal API
cryptodev: remove LIST_END enumerators
test/crypto-perf: support lookaside IPsec