Re: [dpdk-dev] [PATCH 2/3] drivers/net: temporary disable ixgbe and txgbe
From: Zhang, Roy Fan <hidden>
Date: 2021-10-12 12:27:09
Hi Akhil, Looks like you commented out ixgbe/txgbe from build in this patch, but you didn't add them back in in the next patch? Regards, Fan
quoted hunk ↗ jump to hunk
-----Original Message----- From: Akhil Goyal <redacted> Sent: Thursday, September 30, 2021 3:50 PM To: dev@dpdk.org Cc: thomas@monjalon.net; david.marchand@redhat.com; hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo [off-list ref]; Trahe, Fiona [off-list ref]; Doherty, Declan [off-list ref]; matan@nvidia.com; g.singh@nxp.com; Zhang, Roy Fan [off-list ref]; jianjay.zhou@huawei.com; asomalap@amd.com; ruifeng.wang@arm.com; Ananyev, Konstantin [off-list ref]; Nicolau, Radu [off-list ref]; ajit.khaparde@broadcom.com; rnagadheeraj@marvell.com; adwivedi@marvell.com; Power, Ciara [off-list ref]; Akhil Goyal [off-list ref]; Jian Wang [off-list ref]; Jiawen Wu [off-list ref]; Wang, Haiyue [off-list ref] Subject: [PATCH 2/3] drivers/net: temporary disable ixgbe and txgbe The PMDs ixgbe and txgbe are currently making rte_security_session private data as constant, but they are getting filled inside the API. This was feasible as the session_private_data and rte_security_session pointers were separate. But now these two will be from same memory chunk. Hence it cannot use them as const. Need help from PMD owners to fix this. Cc: Jian Wang <redacted> Cc: Jiawen Wu <jiawenwu@trustnetic.com> Cc: Haiyue Wang <redacted> Cc: Fan Zhang <redacted> Signed-off-by: Akhil Goyal <redacted> --- drivers/net/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/net/meson.build b/drivers/net/meson.build index bcf488f203..4c0cd50cd5 100644 --- a/drivers/net/meson.build +++ b/drivers/net/meson.build@@ -30,7 +30,7 @@ drivers = [ 'igc', 'ionic', 'ipn3ke', - 'ixgbe', + # 'ixgbe', 'kni', 'liquidio', 'memif',@@ -55,7 +55,7 @@ drivers = [ 'szedata2', 'tap', 'thunderx', - 'txgbe', +# 'txgbe', 'vdev_netvsc', 'vhost', 'virtio', --2.25.1