Thread (29 messages) 29 messages, 5 authors, 2021-10-22

Re: [dpdk-dev] [PATCH v2 1/2] lib/cmdline: release cl when cmdline exit

From: Peng, ZhihongX <hidden>
Date: 2021-09-30 06:47:53

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Peng, ZhihongX <redacted>
Sent: Friday, September 17, 2021 10:15 AM
To: olivier.matz@6wind.com; stephen@networkplumber.org
Cc: dev@dpdk.org; Peng, ZhihongX <redacted>;
stable@dpdk.org
Subject: [PATCH v2 1/2] lib/cmdline: release cl when cmdline exit

From: Zhihong Peng <redacted>

Malloc cl in the cmdline_stdin_new function, so release in the
cmdline_stdin_exit function is logical, so that cl will not be released alone.

Fixes: af75078fece3 (first public release)
Cc: stable@dpdk.org

Signed-off-by: Zhihong Peng <redacted>
---
 lib/cmdline/cmdline_socket.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c
index 998e8ade25..ebd5343754 100644
--- a/lib/cmdline/cmdline_socket.c
+++ b/lib/cmdline/cmdline_socket.c
@@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl)
 		return;

 	terminal_restore(cl);
+	cmdline_free(cl);
 }
--
2.25.1
Tested-by: Zhihong Peng <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help