Thread (29 messages) 29 messages, 5 authors, 2021-10-22

Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2021-08-31 16:59:09

On Tue, 31 Aug 2021 10:28:44 +0800
zhihongx.peng@intel.com wrote:
quoted hunk ↗ jump to hunk
From: Zhihong Peng <redacted>

Malloc cl in the cmdline_stdin_new function, so release in the
cmdline_stdin_exit function is logical, so that cl will not be
released alone.

Fixes: af75078fece3 (first public release)
Cc: stable@dpdk.org

Signed-off-by: Zhihong Peng <redacted>
---
 lib/cmdline/cmdline_socket.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c
index 998e8ade25..ebd5343754 100644
--- a/lib/cmdline/cmdline_socket.c
+++ b/lib/cmdline/cmdline_socket.c
@@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl)
 		return;
 
 	terminal_restore(cl);
+	cmdline_free(cl);
 }
How did you find this? valgrind? address-sanitizer?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help