Thread (245 messages) 245 messages, 11 authors, 2022-02-08

Re: [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows

From: Dmitry Kozlyuk <hidden>
Date: 2021-08-31 17:39:58

2021-08-31 10:01 (UTC-0700), Jie Zhou:
On Sun, Aug 29, 2021 at 01:18:12AM +0300, Dmitry Kozlyuk wrote:
quoted
2021-08-18 10:13 (UTC-0700), Jie Zhou:  
quoted
In app/test/meson.build
- Specify the subset of source files to compile on Windows
- Specify the subset of tests to be enabled on Windows
Signed-off-by: Jie Zhou <redacted>
---
 app/test/meson.build | 859 ++++++++++++++++++++++++++-----------------
 1 file changed, 515 insertions(+), 344 deletions(-)  
Commit messages should explain the reason for the change,
which itself is precisely described by the diff below.
For example, why these specific tests are selected?

Please don't create two lists, it will be hard to maintain.
 
Since not all the libraries unit tests depend on are built on Windows yet, and not all unit tests are ported on Windows yet, what would be a proper way to have one list but only a subset of the list actually enabled on Windows? Thanks for any suggestions.
I would put all the common tests to the list first,
then extend the list depending on the platform.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help