Re: [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows
flat view
From: Dmitry Kozlyuk <hidden>
Date: 2021-08-28 22:18:16
2021-08-18 10:13 (UTC-0700), Jie Zhou:
In app/test/meson.build - Specify the subset of source files to compile on Windows - Specify the subset of tests to be enabled on Windows Signed-off-by: Jie Zhou <redacted> --- app/test/meson.build | 859 ++++++++++++++++++++++++++----------------- 1 file changed, 515 insertions(+), 344 deletions(-)
Commit messages should explain the reason for the change, which itself is precisely described by the diff below. For example, why these specific tests are selected? Please don't create two lists, it will be hard to maintain.
quoted hunk ↗ jump to hunk
diff --git a/app/test/meson.build b/app/test/meson.build index 7240304916..1e77657510 100644 --- a/app/test/meson.build +++ b/app/test/meson.build
[...]
quoted hunk ↗ jump to hunk
@@ -362,7 +533,7 @@ endif if dpdk_conf.has('RTE_EVENT_SKELETON') test_deps += 'event_skeleton' endif -if dpdk_conf.has('RTE_LIB_TELEMETRY') +if not(is_windows) and dpdk_conf.has('RTE_LIB_TELEMETRY') test_sources += ['test_telemetry_json.c', 'test_telemetry_data.c'] fast_tests += [['telemetry_json_autotest', true], ['telemetry_data_autotest', true]] endif
"not" is not a function, "if not is_windows and ..." is the preferred style.