On 8/17/2021 3:44 PM, Ferruh Yigit wrote:

On 7/29/2021 2:47 PM, Heinrich Kuhn wrote:

quoted

The majority of "ethdev" type functions are used for both PF devices and
VF devices. Prototype these functions in the nfp_net_pmd header file in
preparation of splitting PF and VF specific functions.

Signed-off-by: Heinrich Kuhn <redacted>
Signed-off-by: Simon Horman <redacted>
---
 drivers/net/nfp/nfp_net.c     | 87 +++++++++++++----------------------
 drivers/net/nfp/nfp_net_pmd.h | 49 ++++++++++++++++++++
 2 files changed, 81 insertions(+), 55 deletions(-)

<...>


Following functions seems only used in this file, and you may want to keep them
'static':
nfp_net_dev_link_status_print
nfp_net_irq_unmask
nfp_net_dev_interrupt_delayed_handler
nfp_net_rss_reta_write
nfp_net_rss_hash_write

(I may be missed some, you may want to double check all.)

Rest of the set looks good to me.

Since rest is OK, I will make above functions static while merging, if they
needs to be used by other files they can always be updated again.