On 2021/07/23 11:18, Thomas Monjalon wrote:

16/07/2021 10:35, Heinrich Kuhn:

quoted

This patch set restructures the NFP PMD, aligning it more with the
common layout adopted by most other PMD's. Although the changes look
fairly large, functionally nothing is added or removed from the driver
and the existing code is mostly just reorganized into the familiar
structure seen in other PMD's.

It seems this refactoring is destroying this firmware improvement:
	https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781

Please rebase carefully, keeping the behaviour really intact.

quoted

Apart form adopting the common PMD layout
this change should also aid in future feature development to the NFP
PMD. The previous layout where most of the logic resided in a single
file (nfp_net.c) would have become tedious to support going forward.

Thanks Thomas, I actually finished this work earlier in the month and

just missed your firmware helper addition. I posted v3 of this rework