On Fri, Jul 30, 2021 at 4:00 PM Thomas Monjalon [off-list ref] wrote:

30/07/2021 12:24, Jerin Jacob:

quoted

On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
[off-list ref] wrote:

quoted

quoted

-----Original Message-----
From: Jerin Jacob <redacted>
Sent: Wednesday, July 28, 2021 3:01 PM
To: Jayatheerthan, Jay <redacted>
Cc: Naga Harish K, S V <redacted>; dev@dpdk.org
Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter

quoted

quoted

quoted

quoted

Signed-off-by: Naga Harish K, S V <redacted>

@Naga Harish K, S V Can we remove "," from the Signoff name.

Some suggestions for consideration in preferred order. Let me know
your preferred Signoff name, I will change it accordingly.

Naga Harish [off-list ref]

or

Naga Harish K [off-list ref]

or

Naga Harish K S V [off-list ref]

This option is good. (Harish is out and hence I am responding)

1)  Option 'Signed-off-by: Naga Harish K S V
[off-list ref] is warned by checkpatch

[for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1

### eventdev: fix event port setup in Tx adapter

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
mismatch: 'From: "Naga Harish K, S V" [off-list ref]'
!= 'Signed-off-by: Naga Harish K S V [off-list ref]'

2)  Option 'Signed-off-by: Naga Harish K, S V
[off-list ref]' is warning by check-git-log.sh

[for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
Wrong tag:
        Signed-off-by: Naga Harish K, S V [off-list ref]


@thomas @David Marchand

Could you suggest what Sign-off to take?

The first option is probably OK but the problem is a mismatch with the author name.
Make sure to change the authorship with --amend --author=

Thanks for the input.