Thread (11 messages) 11 messages, 4 authors, 2021-07-30

Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

From: Jerin Jacob <hidden>
Date: 2021-07-28 09:31:01

On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay
[off-list ref] wrote:
quoted
-----Original Message-----
From: Naga Harish K, S V <redacted>
Sent: Saturday, July 24, 2021 7:41 PM
To: Jayatheerthan, Jay <redacted>; jerinjacobk@gmail.com
Cc: dev@dpdk.org
Subject: [PATCH v2] eventdev: fix event port setup in tx adapter

The event port config set by application in
rte_event_eth_tx_adapter_create API is modified in
default configuration callback function. This patch removes
this hardcode to use application provided event port
config value.

Fixes: ("eventdev: fix event port config override in tx adapter")
@Jerin, does this look good to you ?
Yes. I will merge this. See below.
quoted
Signed-off-by: Naga Harish K, S V <redacted>

@Naga Harish K, S V Can we remove "," from the Signoff name.

Some suggestions for consideration in preferred order. Let me know
your preferred Signoff name, I will change it accordingly.

Naga Harish [off-list ref]

or

Naga Harish K [off-list ref]

or

Naga Harish K S V [off-list ref]
quoted
---
 lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index db260bfb68..18c0359db7 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
              return ret;
      }

-     pc->event_port_cfg = 0;
      ret = rte_event_port_setup(dev_id, port_id, pc);
      if (ret) {
              RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
--
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help