Hello, 

-----Original Message-----
From: Thomas Monjalon <redacted>
Sent: Friday, July 23, 2021 8:57 PM
To: Slava Ovsiienko <redacted>; Jiawei(Jonny) Wang
[off-list ref]
Cc: Matan Azrad <redacted>; Ori Kam <redacted>;
Shahaf Shuler [off-list ref]; dev@dpdk.org; Raslan Darawsheh
[off-list ref]; stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation

23/07/2021 14:43, Jiawei Wang:

quoted

Due to hardware limitations, the decap action can't follow the

Which decap action? Pleas be more specific.

All of decap,  vxlan_decap, nvgre_decap and raw_decap.
Will update details.

quoted

sample action in the same flow, to keep the original action order of
sample and decap actions the flow was internally split by PMD, and
decap action was moved into suffix subflow in the new table.

"the" new table? which one?

" sample and decap actions the flow was internally split by PMD, " means
that PMD split internally into two flows:prefix subflow with sample action in original table;
suffix subflow with decap action in the new table;

Was there an issue? Above seems to say all is fine.

The issue is mentioned below that 'L3 encapsulation' case (raw_decap+raw_encap), 
the previous code not consier the combination decap/encap case.
And under this case flow don't need split.

quoted

There is a specific combination of raw decap and raw encap actions to
specify "L3 encapsulation" packet transformation - raw decap action to
remove L2 header and raw encap to add the tunnel header.

Is this combination the problem? It was not working before this patch?
Please describe what happened.

L3 encap is working without sample action or sample is working without L3 encap;

quoted

This specific L3 encapsulation is encoded as a single packet reformat
hardware transaction and is supported by hardware after sample action
(no hardware limitations for packet reformat).

The patch checks whether the decap action is the part of "L3

encapsulation"

I think you mean "is part of".

Thanks, will fix in new version.

quoted

and does not move the decap action into suffix subflow for the case.

Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions
with mirror")
Cc: stable@dpdk.org

Signed-off-by: Jiawei Wang <redacted>
Acked-by: Viacheslav Ovsiienko <redacted>

Thanks.