Re: [dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation
From: Thomas Monjalon <hidden>
Date: 2021-07-23 12:57:10
23/07/2021 14:43, Jiawei Wang:
Due to hardware limitations, the decap action can't follow the
Which decap action? Pleas be more specific.
sample action in the same flow, to keep the original action order of sample and decap actions the flow was internally split by PMD, and decap action was moved into suffix subflow in the new table.
"the" new table? which one? Was there an issue? Above seems to say all is fine.
There is a specific combination of raw decap and raw encap actions to specify "L3 encapsulation" packet transformation - raw decap action to remove L2 header and raw encap to add the tunnel header.
Is this combination the problem? It was not working before this patch? Please describe what happened.
This specific L3 encapsulation is encoded as a single packet reformat hardware transaction and is supported by hardware after sample action (no hardware limitations for packet reformat). The patch checks whether the decap action is the part of "L3 encapsulation"
I think you mean "is part of".
and does not move the decap action into suffix subflow for the case.
Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions with mirror")
Cc: stable@dpdk.org
Signed-off-by: Jiawei Wang <redacted>
Acked-by: Viacheslav Ovsiienko <redacted>