Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading
From: Wang, Haiyue <hidden>
Date: 2021-07-05 13:18:16
-----Original Message----- From: dev <redacted> On Behalf Of David Marchand Sent: Tuesday, June 29, 2021 16:07 To: dev@dpdk.org Cc: Yang, Qiming <redacted>; Zhang, Qi Z <redacted> Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading Both "normal" and "dcf" inits have their copy of some firmware loading code. The DSN query is moved in specific parts for the "normal" and "dcf" init. A common helper ice_load_pkg is then introduced and takes an adapter pointer as its main input. This helper takes care of finding the right firmware file and loading it. The adapter active_pkg_type field is set by this helper. The ice_access macro is removed from the osdep.h header: osdep.h should only hosts wrappers for base driver code. Signed-off-by: David Marchand <redacted> --- drivers/net/ice/base/ice_osdep.h | 6 -- drivers/net/ice/ice_dcf_parent.c | 97 ++----------------- drivers/net/ice/ice_ethdev.c | 161 +++++++++++++++---------------- drivers/net/ice/ice_ethdev.h | 3 +- 4 files changed, 88 insertions(+), 179 deletions(-)
Squash into a single patch seems great help to understand the compress firmware context. ;-) But it's OK as two patches. Acked-by: Haiyue Wang <redacted>
-- 2.23.0