-----Original Message-----
From: Zhang, Qi Z <redacted>
Sent: Monday, July 5, 2021 18:00
To: David Marchand <redacted>; Wang, Haiyue <redacted>
Cc: dev@dpdk.org; Yang, Qiming <redacted>
Subject: RE: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

quoted

-----Original Message-----
From: David Marchand <redacted>
Sent: Monday, July 5, 2021 4:34 PM
To: Wang, Haiyue <redacted>
Cc: dev@dpdk.org; Yang, Qiming <redacted>; Zhang, Qi Z
[off-list ref]
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

On Mon, Jul 5, 2021 at 10:02 AM Wang, Haiyue [off-list ref]
wrote:

quoted

quoted

quoted

I'm wondering what's full name for ice firmware in F34, has any
*.xz postfix ? If so, the search method will also needs to be
updated, since we will check each file can be accessed:

#define ICE_PKG_FILE_DEFAULT "/lib/firmware/intel/ice/ddp/ice.pkg"
#define ICE_PKG_FILE_UPDATES

"/lib/firmware/updates/intel/ice/ddp/ice.pkg"

quoted

quoted

This first patch is a preparation to have a single helper to
select/open the firmware.
I don't get what you mean.

Since the pkg file has the *.xz, now the search method doesn't work.
You fix the read only. ;-)

This patch fixes nothing wrt to F34.
It simply prepares for the next patch, because I did not want to fix in two places
with the same change.

I agree with this , the patch just do code refactory, it looks good to have , no matter if we need
this for F34 or not.

Haiyue, did you see any problem on F34 with both patches be applied or just this one be applied?

Just install a VM to see the firmware name, not test yet. ;-)

quoted

I can squash everything in a single patch if you prefer.

quoted

In the end, I end up with the same question, but for the whole series:

quoted

quoted

Is there a change in behavior with this patch?

--
David Marchand