Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number
From: Ruifeng Wang <hidden>
Date: 2021-06-21 01:53:07
-----Original Message----- From: Thomas Monjalon <redacted> Sent: Friday, June 18, 2021 4:58 PM To: Ruifeng Wang <redacted>; Thierry Herbelot [off-list ref] Cc: dev@dpdk.org; jerinj@marvell.com; Honnappa Nagarahalli [off-list ref]; Juraj Linkeš [off-list ref]; nd [off-list ref] Subject: Re: [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number 18/06/2021 10:53, Thierry Herbelot:quoted
On 6/18/21 10:51 AM, Thomas Monjalon wrote:quoted
18/06/2021 04:09, Ruifeng Wang:quoted
From: Thierry Herbelot <redacted>quoted
'part_number_config': { - '0xc00': {'machine_args': ['-march=armv8-a+crc']} + '0x800': {'machine_args': ['-march=armv8-a+crc']}, + '0xc00': {'machine_args': ['-march=armv8-a+crc']},Nit, redundant comma at the end of the line.What is redundant?The comma at the end of the second line is not necessary.It is a good practice to have comma like other lines, so no need to update this line when adding more.
Looked at style in the rest of the file. Just wanted them to be aligned. I'm fine with a trailing comma at the last line. Acked-by: Ruifeng Wang <redacted>