Thread (16 messages) 16 messages, 4 authors, 2021-05-12

Re: [dpdk-dev] [dpdk-stable] [PATCH v1 2/4] test/power: add turbo mode to freq check function

From: David Hunt <hidden>
Date: 2021-05-12 16:39:02

On 12/5/2021 4:34 PM, Thomas Monjalon wrote:
22/04/2021 18:13, Burakov, Anatoly:
quoted
On 22-Apr-21 3:40 PM, David Hunt wrote:
quoted
--- a/app/test/test_power_cpufreq.c
+++ b/app/test/test_power_cpufreq.c
@@ -48,7 +48,7 @@ static uint32_t total_freq_num;
   static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX];
   
   static int
-check_cur_freq(unsigned lcore_id, uint32_t idx)
+check_cur_freq(unsigned int lcore_id, uint32_t idx, int turbo)
Nitpicking, but stdbool exists :) it would be nice to use bool type for
bool variables, not int.
Dave, I think you missed this comment.
Thanks for the reminder Thomas, I've just pushed a new version replacing 
the int with a bool.

Regards,
Dave.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help