Re: [dpdk-dev] [dpdk-stable] [PATCH v1 1/4] test/power: fix check for cpu frequency
From: Thomas Monjalon <hidden>
Date: 2021-05-11 13:27:40
From: Thomas Monjalon <hidden>
Date: 2021-05-11 13:27:40
This patch series is stucked. That's too often the case for the power lib/example/test patches. 29/04/2021 12:34, Pattan, Reshma:
From: dev <redacted> On Behalf Of David Huntquoted
+TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) {quoted
return 0;[Reshma]: Do we need to return -1 here and in other failure scenarios below.quoted
} f = fopen(fullpath, "r"); if (f == NULL) { -return 0; +if (snprintf(fullpath, sizeof(fullpath), +TEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) { +return 0; +} +f = fopen(fullpath, "r"); +if (f == NULL) { +return 0; +} }