Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD
From: Matan Azrad <hidden>
Date: 2021-05-12 05:32:04
From: Matan Azrad <hidden>
Date: 2021-05-12 05:32:04
From: Akhil Goyal
quoted
quoted
quoted
quoted
quoted
+fmt_name = 'mlx5_crypto' +deps += ['common_mlx5', 'eal', 'cryptodev']I don't see a reason for eal dependency. Do you really need it?See RTE_LOG_REGISTER.Compilation works fine even after removing this dependency. I believe it is internally managed in cryptodev.Yes, but it is better to add the libs we use directly.Please remove eal so that it is consistent with other PMDs
I don't understand why you don't give a claim to explain why not to add libs the PMD accesses directly. One day when other dependency will remove the direct dependency, it may be problematic. Because I see you strongly insist on it and this is tiny I will remove.