Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API
From: Matan Azrad <hidden>
Date: 2021-05-09 14:24:24
From: Matan Azrad <hidden>
Date: 2021-05-09 14:24:24
-----Original Message----- From: Akhil Goyal <redacted> Sent: Sunday, May 9, 2021 12:19 PM To: Matan Azrad <redacted>; dev@dpdk.org Cc: Suanming Mou <redacted>; NBU-Contact-Thomas Monjalon [off-list ref]; Shiri Kuzin [off-list ref] Subject: RE: [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API External email: Use caution opening links or attachmentsquoted
quoted
Also set feature flag in the code and the documentation in this patch. I see that you are setting all of them in a single patch in the end. This is not correct. It should be added where the feature is supported. Please fix this for all the feature flags.No, in this stage no feature is really supported, the actual time it will be supported is after the datapath patches and capabilities set.Move the patch after adding data path, but documentation should be part Of this patch.
I will squash this patch to the session commit.