On 3/31/2021 1:55 AM, Min Hu (Connor) wrote:

在 2021/3/30 0:10, Ferruh Yigit 写道:

quoted

On 3/23/2021 1:45 PM, Min Hu (Connor) wrote:

quoted

From: Huisong Li <lihuisong@huawei.com>

The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'.
However, the modification in the SVE algorithm is omitted.
As a result, the driver fails to be compiled when the SVE
algorithm is used.

Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <redacted>
---
  drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c 

b/drivers/net/hns3/hns3_rxtx_vec_sve.c
index f8655fa..e1a1731 100644

--- a/drivers/net/hns3/hns3_rxtx_vec_sve.c
+++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c

@@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue,

      nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts);
      if (unlikely(nb_pkts == 0)) {
-        txq->queue_full_cnt++;
+        txq->dfx_stats.queue_full_cnt++;
          return 0;
      }

Hi Connor,

This is a very obvious build error, I am concerned how this is released. Do 
you have any internal testing?

Hi Ferruh,
     Well, we admit it is our mistake for this issue. Let me
describe the reason:
     Firstly, we must declare that we have our inner CI system for
building and testing. While when we upstream the ""support SVE" patch,
our CI does not support SVE building. Instead we build and test SVE on
our local platform.
     Then when we upstream the "encapsulate DFX stats in datapath"
patch, we only build it in CI(at that time, SVE building is still not 
supported), regardless of SVE building on local platform.
     Now, SVE building is supported in our CI， So the building error
occurs.
     We'll pay more attention to the issue in the future. Thanks.

Good to hear your internal testing covers SVE now, thanks for clarification.