Ferruh Yigit [off-list ref] writes:

On 3/23/2021 1:45 PM, Min Hu (Connor) wrote:

quoted

From: Huisong Li <lihuisong@huawei.com>

The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'.
However, the modification in the SVE algorithm is omitted.
As a result, the driver fails to be compiled when the SVE
algorithm is used.

Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <redacted>
---
  drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c
index f8655fa..e1a1731 100644
--- a/drivers/net/hns3/hns3_rxtx_vec_sve.c
+++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c

@@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue,
    	nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts);
  	if (unlikely(nb_pkts == 0)) {
-		txq->queue_full_cnt++;
+		txq->dfx_stats.queue_full_cnt++;
  		return 0;
  	}
  

Hi Connor,

This is a very obvious build error, I am concerned how this is
released. Do you have any internal testing?

+ Aaron & Honnappa,

If we can have a build test in our public CI with SVE?

Maybe it's possible - we might need to expand the aarch64 cross builds
with a bit of extra information.  I'm not sure which compiler is needed,
though.  Currently, we install whatever ubuntu18.04 is providing - I
don't know if it has the SVE extensions needed.  Honnappa/ARM folks can
provide more information that way - though I would expect it's just a
setting that can be changed in the host_machine or properties section of
the cross-config file.

If that's known (maybe we need to use the thunderx2 config or something
else?  I don't know too much about enabling compiler support for SVE),
then we should probably hook it up.