Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations
From: Ferruh Yigit <hidden>
Date: 2021-03-24 18:06:03
On 3/21/2021 9:00 AM, Thomas Monjalon wrote:
Since rte_flow is the only API for filtering operations, the legacy driver interface filter_ctrl was too much complicated for the simple task of getting the struct rte_flow_ops. The filter type RTE_ETH_FILTER_GENERIC and the filter operarion RTE_ETH_FILTER_GET are removed. The new driver callback flow_ops_get replaces filter_ctrl. Signed-off-by: Thomas Monjalon <redacted> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Acked-by: Haiyue Wang <redacted> Acked-by: Rosen Xu <redacted> Acked-by: Hemant Agrawal <redacted>
Except from following minor issue, Reviewed-by: Ferruh Yigit <redacted>
quoted hunk ↗ jump to hunk
--- a/drivers/net/dpaa2/dpaa2_flow.c +++ b/drivers/net/dpaa2/dpaa2_flow.c@@ -89,8 +89,6 @@ enum rte_flow_action_type dpaa2_supported_action_type[] = { /* Max of enum rte_flow_item_type + 1, for both IPv4 and IPv6*/ #define DPAA2_FLOW_ITEM_TYPE_GENERIC_IP (RTE_FLOW_ITEM_TYPE_META + 1) -enum rte_filter_type dpaa2_filter_type = RTE_ETH_FILTER_NONE; -
Need to remove the 'dpaa2_filter_type' extern from 'dpaa2_ethdev.h' too.