Re: [dpdk-dev] [PATCH 1/2] ethdev: replace callback getting filter operations
From: Thomas Monjalon <hidden>
Date: 2021-03-12 08:22:48
From: Thomas Monjalon <hidden>
Date: 2021-03-12 08:22:48
12/03/2021 02:44, Wang, Haiyue:
From: Thomas Monjalon <redacted>quoted
-typedef int (*eth_filter_ctrl_t)(struct rte_eth_dev *dev, - enum rte_filter_type filter_type, - enum rte_filter_op filter_op, - void *arg); -/**< @internal Take operations to assigned filter type on an Ethernet device */ +struct rte_flow_ops; +typedef int (*eth_flow_ops_get_t)(struct rte_eth_dev *dev, + const struct rte_flow_ops **ops); +/**< @internal Get flow operations */How about to change the return type to "const struct rte_flow_ops *" directly ? typedef const struct rte_flow_ops * (*eth_flow_ops_get_t)(struct rte_eth_dev *dev);
Not sure. Returning an int may allow different error codes. Any opinions?