Thread (61 messages) 61 messages, 7 authors, 2021-03-17

Re: [dpdk-dev] [PATCH v6 2/2] bus/pci: support MMIO in PCI ioport accessors

From: David Marchand <hidden>
Date: 2021-02-18 09:33:23

On Wed, Feb 17, 2021 at 3:15 PM 谢华伟(此时此刻) [off-list ref] wrote:

On 2021/2/17 17:06, David Marchand wrote:
quoted
On Fri, Jan 29, 2021 at 4:19 AM 谢华伟(此时此刻) [off-list ref] wrote:
quoted
@@ -517,6 +525,60 @@
  }
  #endif

+static inline uint8_t ioread8(void *addr)
+{
+       uint8_t val;
+
+       val = (uint64_t)(uintptr_t)addr >= PIO_MAX ?
+               *(volatile uint8_t *)addr :
+               inb((unsigned long)addr);
inb/outb and others are architecture (x86?) specific.
Yes, only X86 has PIO.
Ok, thanks for confirming.
quoted
The CI caught this issue, see build failures on ARM64.
https://lab.dpdk.org/results/dashboard/results/results-uploads/test_runs/82432e287bc94831b7a65d7cd6f05783/log_upload_file/2021/2/dpdk_b49c677a0d24_15433_2021-02-01_00-15-59_NA.zip

I can see the same issue with ppc64le.
Just to be clear.
This series can't be merged as it breaks non-x86 architectures.


-- 
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help