Thread (62 messages) 62 messages, 3 authors, 2021-02-24

Re: [dpdk-dev] [PATCH 7/7] net/dpaa2: add support to configure dpdmux max Rx frame len

From: Hemant Agrawal <hidden>
Date: 2021-02-04 10:46:15

HI Ferruh,

On 2/2/2021 5:08 PM, Ferruh Yigit wrote:
On 1/20/2021 2:27 PM, Hemant Agrawal wrote:
quoted
This patch introduce a new pmd api, which can help the applications
to configure the max framelen for a given dpdmux interface

Signed-off-by: Hemant Agrawal <redacted>
<...>
quoted
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change, or be removed, without 
prior notice
+ *
+ * demultiplex interface max rx frame length configure
+ *
+ * @param dpdmux_id
+ *    ID of the DPDMUX MC object.
+ * @param max_rx_frame_len
+ *    maximum receive frame length (will be checked to be minimux of 
all dpnis)
+ *
+ */
+__rte_experimental
+int
+rte_pmd_dpaa2_mux_rx_frame_len(uint32_t dpdmux_id, uint16_t 
max_rx_frame_len);
+
PMD specific APIs are not good for portability, and I think better to 
reduce them as much as possible.

Can't this new parameter provided as devarg, instead of a new PMD API?
Applications controls it w.r.t jumbo buffers for the dpdmux attached 
interfaces. So, devargs will not work in this case.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help