Re: [dpdk-dev] [PATCH 7/7] net/dpaa2: add support to configure dpdmux max Rx frame len
From: Ferruh Yigit <hidden>
Date: 2021-02-02 11:38:59
From: Ferruh Yigit <hidden>
Date: 2021-02-02 11:38:59
On 1/20/2021 2:27 PM, Hemant Agrawal wrote:
This patch introduce a new pmd api, which can help the applications to configure the max framelen for a given dpdmux interface Signed-off-by: Hemant Agrawal <redacted>
<...>
+/** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * + * demultiplex interface max rx frame length configure + * + * @param dpdmux_id + * ID of the DPDMUX MC object. + * @param max_rx_frame_len + * maximum receive frame length (will be checked to be minimux of all dpnis) + * + */ +__rte_experimental +int +rte_pmd_dpaa2_mux_rx_frame_len(uint32_t dpdmux_id, uint16_t max_rx_frame_len); +
PMD specific APIs are not good for portability, and I think better to reduce them as much as possible. Can't this new parameter provided as devarg, instead of a new PMD API?