Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio HW struct
From: Maxime Coquelin <hidden>
Date: 2021-01-15 09:35:48
From: Maxime Coquelin <hidden>
Date: 2021-01-15 09:35:48
On 1/6/21 10:58 AM, David Marchand wrote:
On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin [off-list ref] wrote:quoted
This patch improves the virtio_hw struct packing, going from 88 down to 80 bytes with a 6 bytes hole in the end of the first cacheline. Fields only used in the slow path are placed in the end, so that hot path only uses the first cacheline.This also changes some boolean fields to uint8_t but we still assign the true/false values to them (in some cases). This works, but I would align those fields' assignments to this type change.
Fixed, note it was already inconsistent for some. Thanks, Maxime