Re: [dpdk-dev] [PATCH 02/40] net/virtio: Introduce Virtio bus type

On Thu, Jan 14, 2021 at 11:55 AM Maxime Coquelin
[off-list ref] wrote:

quoted

quoted

quoted

@@ -1919,7 +1918,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
        eth_dev->rx_descriptor_done = virtio_dev_rx_queue_done;

        if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
-               if (!hw->virtio_user_dev) {
+               if (hw->bus_type != VIRTIO_BUS_USER) {

In the rest of the patch, we check for PCI types when dealing with PCI
code, so I'd rather be consistent and check for modern and legacy pci
types here too.

Agree, it is not consistent. I fixed it here and below for v2.

Wait, as we discussed off-list, we need hw->bus_type != VIRTIO_BUS_USER,
as the bus_type is still unknown for PCI bus at that stage.

Yep, thanks for double checking.


-- 
David Marchand