On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote:

External Email

----------------------------------------------------------------------
Friendly ping.

Hi Wang,

   I am sorry for the delay in review, I will surely complete the review
   by end of this week.
   Can you please elaborate on the specific case/scenario which caused
   failure i.e. which lead you to this change.

Thanks
Harman

quoted

-----Original Message-----
From: wangyunjian
Sent: Wednesday, August 26, 2020 6:56 PM
To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com
Cc: 'ferruh.yigit@intel.com' <redacted>; 'Thomas Monjalon'
[off-list ref]; Lilijun (Jerry) [off-list ref]; xudingke
[off-list ref]; stable@dpdk.org
Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for
rte_epoll_event

Ping for review, please.

quoted

-----Original Message-----
From: wangyunjian
Sent: Wednesday, July 15, 2020 10:40 AM
To: dev@dpdk.org; hkalra@marvell.com
Cc: Lilijun (Jerry) <redacted>; xudingke
[off-list ref]; wangyunjian [off-list ref];
stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for
rte_epoll_event

From: Yunjian Wang <redacted>

The "rev->epdata.event" assigned to "events.epdata.event" directly,
which was wrong in case of epoll events. It should be set to the "evs.events".

Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <redacted>
---
 lib/librte_eal/linux/eal_interrupts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linux/eal_interrupts.c

b/lib/librte_eal/linux/eal_interrupts.c
index 13db5c4e8..8a3c95cec 100644

--- a/lib/librte_eal/linux/eal_interrupts.c
+++ b/lib/librte_eal/linux/eal_interrupts.c

@@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs,

unsigned int n,
 		events[count].status        = RTE_EPOLL_VALID;
 		events[count].fd            = rev->fd;
 		events[count].epfd          = rev->epfd;
-		events[count].epdata.event  = rev->epdata.event;
+		events[count].epdata.event  = evs[i].events;
 		events[count].epdata.data   = rev->epdata.data;
 		if (rev->epdata.cb_fun)
 			rev->epdata.cb_fun(rev->fd,
--
2.23.0