Thread (10 messages) 10 messages, 3 authors, 2021-01-11

Re: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

From: wangyunjian <hidden>
Date: 2020-08-26 10:55:54

Ping for review, please.
quoted hunk ↗ jump to hunk
-----Original Message-----
From: wangyunjian
Sent: Wednesday, July 15, 2020 10:40 AM
To: dev@dpdk.org; hkalra@marvell.com
Cc: Lilijun (Jerry) <redacted>; xudingke
[off-list ref]; wangyunjian [off-list ref];
stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

From: Yunjian Wang <redacted>

The "rev->epdata.event" assigned to "events.epdata.event" directly, which
was wrong in case of epoll events. It should be set to the "evs.events".

Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <redacted>
---
 lib/librte_eal/linux/eal_interrupts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linux/eal_interrupts.c
b/lib/librte_eal/linux/eal_interrupts.c
index 13db5c4e8..8a3c95cec 100644
--- a/lib/librte_eal/linux/eal_interrupts.c
+++ b/lib/librte_eal/linux/eal_interrupts.c
@@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs,
unsigned int n,
 		events[count].status        = RTE_EPOLL_VALID;
 		events[count].fd            = rev->fd;
 		events[count].epfd          = rev->epfd;
-		events[count].epdata.event  = rev->epdata.event;
+		events[count].epdata.event  = evs[i].events;
 		events[count].epdata.data   = rev->epdata.data;
 		if (rev->epdata.cb_fun)
 			rev->epdata.cb_fun(rev->fd,
--
2.23.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help