Re: [dpdk-dev] [PATCH 18/21] net/ixgbe/base: ipv6 Mask for purpose FDIR VLAN Port Feature

Hi Ferruh

-----Original Message-----
From: Yigit, Ferruh
Sent: Monday, June 22, 2020 8:01 PM
To: Sun, GuinanX <redacted>; dev@dpdk.org
Cc: Skajewski, PiotrX <redacted>
Subject: Re: [dpdk-dev] [PATCH 18/21] net/ixgbe/base: ipv6 Mask for purpose
FDIR VLAN Port Feature

On 6/12/2020 4:24 AM, Guinan Sun wrote:

quoted

Allow Flow Director Filter to set IPv6 rules without setting IPv6
source/destination address.

Patch title is hard to understand, commit log is more clear, but title talks about
the VLAN, but description looks different. Can you please clarify?

Patch v2 will modify the patch title.

quoted

Signed-off-by: Piotr Skajewski <redacted>
Signed-off-by: Guinan Sun <redacted>
---
 drivers/net/ixgbe/base/ixgbe_82599.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c

b/drivers/net/ixgbe/base/ixgbe_82599.c
index e425f28af..69fd4cd3f 100644

--- a/drivers/net/ixgbe/base/ixgbe_82599.c
+++ b/drivers/net/ixgbe/base/ixgbe_82599.c

@@ -1832,6 +1832,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct

ixgbe_hw *hw,

quoted

 				     ~input_mask->formatted.src_ip[0]);
 		IXGBE_WRITE_REG_BE32(hw, IXGBE_FDIRDIP4M,
 				     ~input_mask->formatted.dst_ip[0]);
+		IXGBE_WRITE_REG_BE32(hw, IXGBE_FDIRIP6M, 0xFFFFFFFF);
 	}
 	return IXGBE_SUCCESS;
 }