Re: [dpdk-dev] [PATCH v6 01/11] eal: replace rte_page_sizes with a set of constants
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2020-06-03 02:00:12
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2020-06-03 02:00:12
On Wed, 3 Jun 2020 02:03:19 +0300 Dmitry Kozlyuk [off-list ref] wrote:
Clang on Windows follows MS ABI where enum values are limited to 2^31-1. Enum rte_page_sizes has members valued above this limit, which get wrapped to zero, resulting in compilation error (duplicate values in enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs. Remove rte_page_sizes and replace its values with #define's. This enumeration is not used in public API, so there's no ABI breakage. Announce API changes for 20.08 in documentation. Suggested-by: Jerin Jacob <redacted> Signed-off-by: Dmitry Kozlyuk <redacted>
In this case #define makes more sense. Acked-by: Stephen Hemminger <stephen@networkplumber.org>