Thread (38 messages) 38 messages, 6 authors, 2020-02-05

Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite

From: Honnappa Nagarahalli <hidden>
Date: 2019-09-13 15:47:10

<snip>
quoted
[off-list ref] writes:
quoted
From: Amit Gupta <redacted>

hash_readwrite_lf test always getting TIMEOUT as required time to
finish this test was much longer compare to time required for fast
tests(10s). Hence, the test is being renamed moved to perf test
category for its execution to complete.

Signed-off-by: Amit Gupta <redacted>
---
Okay.  I'll note that we pass the '-t 3' flag, so it is actually
timing out with 30s instead of the default 10.  We do this because
occasionally the lpm6 and table tests would also exceed the 10s
timeout in the travis environment.  I agree, it's better to pull the perf part
of tests out.
quoted
I think there isn't any additional functional test in this readwrite - is that so?
If it is, then we need to also prioritize adding back in some of the
functional testing.  Maybe I misread the lf_autotest, though.
[Wang, Yipeng]
Yes that is my concern too, if we just move all the lock-free test into perf test
then we miss the functional test.
Would any of you like to consider adding a small functional test into the
readwrite or readwrite_lf_functional?
That would be great :)
Yes, I will take up for readwrite_lf_functional. But, I do not have much bandwidth for 19.11. I suggest we move only part of the tests to perf tests instead for 19.11, this would serve both the purposes.

Amit, would it be possible to check what tests will run within the timeout period?
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help