Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
From: Aaron Conole <aconole@redhat.com>
Date: 2019-09-13 14:41:24
[off-list ref] writes:
From: Amit Gupta <redacted> hash_readwrite_lf test always getting TIMEOUT as required time to finish this test was much longer compare to time required for fast tests(10s). Hence, the test is being renamed moved to perf test category for its execution to complete. Signed-off-by: Amit Gupta <redacted> ---
Okay. I'll note that we pass the '-t 3' flag, so it is actually timing out with 30s instead of the default 10. We do this because occasionally the lpm6 and table tests would also exceed the 10s timeout in the travis environment. I agree, it's better to pull the perf part of tests out. I think there isn't any additional functional test in this readwrite - is that so? If it is, then we need to also prioritize adding back in some of the functional testing. Maybe I misread the lf_autotest, though.
quoted hunk ↗ jump to hunk
app/test/meson.build | 2 +- app/test/test_hash_readwrite_lf.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)diff --git a/app/test/meson.build b/app/test/meson.build index 94fd9f8..57d5316 100644 --- a/app/test/meson.build +++ b/app/test/meson.build@@ -220,7 +220,6 @@ fast_test_names = [ 'eventdev_common_autotest', 'fbarray_autotest', 'hash_readwrite_func_autotest', - 'hash_readwrite_lf_autotest', 'ipsec_autotest', 'kni_autotest', 'kvargs_autotest',@@ -263,6 +262,7 @@ perf_test_names = [ 'stack_lf_perf_autotest', 'rand_perf_autotest', 'hash_readwrite_perf_autotest', + 'hash_readwrite_lf_perf_autotest', ] driver_test_names = [diff --git a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c index 1f2fba4..33d63fa 100644 --- a/app/test/test_hash_readwrite_lf.c +++ b/app/test/test_hash_readwrite_lf.c@@ -1431,4 +1431,5 @@ struct { return 0; } -REGISTER_TEST_COMMAND(hash_readwrite_lf_autotest, test_hash_readwrite_lf_main); +REGISTER_TEST_COMMAND(hash_readwrite_lf_perf_autotest, + test_hash_readwrite_lf_main);