Re: [PATCH v3] examples/flow_filtering: add rte_fdir_conf initialization

22/07/2018 12:39, Rosen Xu:

Rte_fdir_conf of rte_eth_conf should be initialized before
port initialization. It is a workaround solution when working
with Intel I40e.

[...]

+		/*
+		 * Initialize fdir_conf of ete_eth_conf

Typo and lack of punctuation.

+		 * it is a workaround solution when working with Intel I40e
+		 * and it is not the normal way

It is not said why it is needed,
and what are we waiting to remove the workaround.

+		 */
+		.fdir_conf = {
+			.mode = RTE_FDIR_MODE_PERFECT,
+			.pballoc = RTE_FDIR_PBALLOC_64K,
+			.status = RTE_FDIR_REPORT_STATUS,
+			.drop_queue = 127,
+		},

Please work on a v4 with better explanations.