Hi,

I have fixed it, thanks.

-----Original Message-----
From: Ori Kam [mailto:orika@mellanox.com]
Sent: Sunday, July 22, 2018 14:34
To: Xu, Rosen <redacted>; dev@dpdk.org
Cc: Yigit, Ferruh <redacted>; Gilmore, Walter E
[off-list ref]; Zhang, Qi Z [off-list ref];
stable@dpdk.org
Subject: RE: [PATCH v2] examples/flow_filtering: add rte_fdir_conf
initialization

quoted

-----Original Message-----
From: Rosen Xu [mailto:rosen.xu@intel.com]
Sent: Saturday, July 21, 2018 10:50 AM
To: dev@dpdk.org
Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam
[off-list ref]; walter.e.gilmore@intel.com;
qi.z.zhang@intel.com; stable@dpdk.org
Subject: [PATCH v2] examples/flow_filtering: add rte_fdir_conf
initialization

Rte_fdir_conf of rte_eth_conf should be initialized before port
initialization. It is a workaround solution when work with Intel I40e.

Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow
API")
Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <redacted>

v2 updates:
===========
 - Take more test on I40e
 - Add comments
---
 examples/flow_filtering/main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/examples/flow_filtering/main.c

b/examples/flow_filtering/main.c index f595034..73d646c 100644

--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c

@@ -132,6 +132,17 @@
 				DEV_TX_OFFLOAD_SCTP_CKSUM  |
 				DEV_TX_OFFLOAD_TCP_TSO,
 		},
+		/*
+		 * Initialize fdir_conf of ete_eth_conf
+		 * it is a workaround solution when work with Intel I40e
+		 * and it is not the normal way
+		 */
+		.fdir_conf = {
+			.mode = RTE_FDIR_MODE_PERFECT,
+			.pballoc = RTE_FDIR_PBALLOC_64K,
+			.status = RTE_FDIR_REPORT_STATUS,
+			.drop_queue = 127,
+		},
 	};
 	struct rte_eth_txconf txq_conf;
 	struct rte_eth_rxconf rxq_conf;
--

1.8.3.1

Just small comment I think work should be replaced with working.
Both in the commit log and code comment.

It's fixed.

Acked-by: Ori Kam <redacted>

Thanks,
Ori