On 17-Jul-18 10:18 AM, Pattan, Reshma wrote:

Hi,

quoted

-----Original Message-----
From: Burakov, Anatoly
Sent: Monday, July 16, 2018 4:16 PM
To: Pattan, Reshma <redacted>; thomas@monjalon.net;
dev@dpdk.org
Cc: Parthasarathy, JananeeX M <redacted>;
stable@dpdk.org
Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list

quoted

+        {
+        "Name":    "Set rxtx mode",
+        "Command": "set_rxtx_mode",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
+    {
+        "Name":    "Set rxtx anchor",
+        "Command": "set_rxtx_anchor",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
+    {
+        "Name":    "Set rxtx sc",
+        "Command": "set_rxtx_sc",
+        "Func":    default_autotest,
+        "Report":  None,
+    },

The above three tests don't look like autotests to me. I have no idea what
they are for, but either they need a special function, or they need to be taken
out.

These commands needs to be run manually from test cmd prompt to various set rxtx mode, rxtx rate and rxtx direction .
These can be used to verify pmd perf test  with vaiours set of above values.

So this can be removed from autotest.

We do have PMD perf tests in the script - do they call these functions? 
If they are required for PMD autotests, maybe PMD autotests deserve a 
special test function calling these commands before running the tests?

(if they also work without these commands, then we can perhaps postpone 
this to 18.11)

quoted

quoted

+        "Name":    "User delay",
+        "Command": "user_delay_us",
+        "Func":    default_autotest,
+        "Report":  None,
+    },

This doesn't look like autotests to me. I have no idea what it is for, but either
it needs a special function, or it needs to be taken out.

This is autotest but the name does'nt have the autotest name in it. So I will retain this.

OK.

-- 
Thanks,
Anatoly