Thread (50 messages) 50 messages, 4 authors, 2018-07-17

Re: [PATCH v3 8/9] autotest: update autotest test case list

From: Pattan, Reshma <hidden>
Date: 2018-07-17 09:18:17

Hi,
-----Original Message-----
From: Burakov, Anatoly
Sent: Monday, July 16, 2018 4:16 PM
To: Pattan, Reshma <redacted>; thomas@monjalon.net;
dev@dpdk.org
Cc: Parthasarathy, JananeeX M <redacted>;
stable@dpdk.org
Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list

quoted
+        {
+        "Name":    "Set rxtx mode",
+        "Command": "set_rxtx_mode",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
+    {
+        "Name":    "Set rxtx anchor",
+        "Command": "set_rxtx_anchor",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
+    {
+        "Name":    "Set rxtx sc",
+        "Command": "set_rxtx_sc",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
The above three tests don't look like autotests to me. I have no idea what
they are for, but either they need a special function, or they need to be taken
out.
These commands needs to be run manually from test cmd prompt to various set rxtx mode, rxtx rate and rxtx direction .
These can be used to verify pmd perf test  with vaiours set of above values.

So this can be removed from autotest.
quoted
+        "Name":    "User delay",
+        "Command": "user_delay_us",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
This doesn't look like autotests to me. I have no idea what it is for, but either
it needs a special function, or it needs to be taken out.
This is autotest but the name does'nt have the autotest name in it. So I will retain this.

Thanks,
Reshma
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help