Thread (45 messages) 45 messages, 4 authors, 2018-07-09

Re: [PATCH 2/2] compressdev: add huffman encoding flags

From: Trahe, Fiona <hidden>
Date: 2018-06-27 17:35:11

quoted
quoted
+	case RTE_COMP_FF_HUFFMAN_FIXED:
+		return "HUFFMAN_FIXED";
+	case RTE_COMP_FF_HUFFMAN_DYNAMIC:
+		return "HUFFMAN_DYNAMIC";
[Fiona] Thanks for adding this.
Just in case any other algos are added in future which also use Huffman
encoding I'd suggest renaming to include DEFLATE, e.g.
RTE_COMP_FF_DFL_HUFFMAN_FIXED/DYNAMIC
Since these flags are set per algorithm (in capabilities),
do you think it is needed to specify DEFLATE?
[Fiona] You're right, I forgot that. So better not to include DEFLATE. 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help