Re: [PATCH] net/qede:fix the bug about pointer params may NULL
From: Patil, Harish <hidden>
Date: 2017-08-25 18:44:01
-----Original Message----- From: dev <redacted> on behalf of Rongqiang XIE [off-list ref] Date: Thursday, August 24, 2017 at 12:12 AM To: "Mody, Rasesh" <redacted> Cc: "dev@dpdk.org" <redacted>, Rongqiang XIE <redacted> Subject: [dpdk-dev] [PATCH] net/qede:fix the bug about pointer params may NULL
quoted hunk ↗ jump to hunk
In function qede_rss_reta_update(),the pointer params returned from call to function rte_zmalloc() may be NULL and will be dereferenced. So, should judge the params is NULL or not. Signed-off-by: Rongqiang XIE <redacted> --- drivers/net/qede/qede_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/net/qede/qede_ethdev.cb/drivers/net/qede/qede_ethdev.c index 0e05989..4e9e89f 100644--- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c@@ -2012,6 +2012,10 @@ int qede_rss_reta_update(struct rte_eth_dev*eth_dev, memset(&vport_update_params, 0, sizeof(vport_update_params)); params = rte_zmalloc("qede_rss", sizeof(*params) * edev->num_hwfns, RTE_CACHE_LINE_SIZE); + if (params == NULL) { + DP_ERR(edev, "failed to allocate memory\n"); + return -ENOMEM; + } for (i = 0; i < reta_size; i++) { idx = i / RTE_RETA_GROUP_SIZE; -- 1.8.3.1 Acked-by: Harish Patil <redacted>