[PATCH] net/qede:fix the bug about pointer params may NULL
From: Rongqiang XIE <hidden>
Date: 2017-08-24 07:13:38
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
In function qede_rss_reta_update(),the pointer params returned from call to function rte_zmalloc() may be NULL and will be dereferenced. So, should judge the params is NULL or not. Signed-off-by: Rongqiang XIE <redacted> --- drivers/net/qede/qede_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 0e05989..4e9e89f 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c@@ -2012,6 +2012,10 @@ int qede_rss_reta_update(struct rte_eth_dev *eth_dev, memset(&vport_update_params, 0, sizeof(vport_update_params)); params = rte_zmalloc("qede_rss", sizeof(*params) * edev->num_hwfns, RTE_CACHE_LINE_SIZE); + if (params == NULL) { + DP_ERR(edev, "failed to allocate memory\n"); + return -ENOMEM; + } for (i = 0; i < reta_size; i++) { idx = i / RTE_RETA_GROUP_SIZE;
--
1.8.3.1