Re: [PATCH] pci: fix level of scan debug log on BSD
From: Bruce Richardson <hidden>
Date: 2017-08-03 10:16:28
On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
quoted hunk ↗ jump to hunk
Printing the number of scanned devices should be a debug log, not an error. Signed-off-by: Thomas Monjalon <redacted> --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c index e321461d8..9335247d8 100644 --- a/lib/librte_eal/bsdapp/eal/eal_pci.c +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c@@ -396,7 +396,7 @@ rte_pci_scan(void) close(fd); - RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count); + RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count); return 0;
would have gone for INFO level myself, but DEBUG works too - it's definitely not an error. The commit title also reads a bit strange to me. How about e.g.: "pci: log fix level of PCI scan summary message on BSD" Otherwise: Acked-by: Bruce Richardson <redacted>