[PATCH] pci: fix level of scan debug log on BSD

Subsystems: library code, the rest

STALE3320d

3 messages, 2 authors, 2017-08-03 · open the first message on its own page

[PATCH] pci: fix level of scan debug log on BSD

From: Thomas Monjalon <hidden>
Date: 2017-07-11 17:10:58

Printing the number of scanned devices should be a debug log,
not an error.

Signed-off-by: Thomas Monjalon <redacted>
---
 lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index e321461d8..9335247d8 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -396,7 +396,7 @@ rte_pci_scan(void)
 
 	close(fd);
 
-	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
+	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
 	return 0;
 
 error:
-- 
2.13.2

Re: [PATCH] pci: fix level of scan debug log on BSD

From: Bruce Richardson <hidden>
Date: 2017-08-03 10:16:28

On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
quoted hunk
Printing the number of scanned devices should be a debug log,
not an error.

Signed-off-by: Thomas Monjalon <redacted>
---
 lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index e321461d8..9335247d8 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -396,7 +396,7 @@ rte_pci_scan(void)
 
 	close(fd);
 
-	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
+	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
 	return 0;
 
would have gone for INFO level myself, but DEBUG works too - it's
definitely not an error.
The commit title also reads a bit strange to me. How about e.g.:
"pci: log fix level of PCI scan summary message on BSD"

Otherwise:
Acked-by: Bruce Richardson <redacted>

Re: [PATCH] pci: fix level of scan debug log on BSD

From: Thomas Monjalon <hidden>
Date: 2017-08-03 15:36:43

03/08/2017 12:16, Bruce Richardson:
On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
quoted
Printing the number of scanned devices should be a debug log,
not an error.

Signed-off-by: Thomas Monjalon <redacted>
---
[...]
quoted
-	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
+	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
 	return 0;
 
would have gone for INFO level myself, but DEBUG works too - it's
definitely not an error.
The commit title also reads a bit strange to me. How about e.g.:
"pci: log fix level of PCI scan summary message on BSD"

Otherwise:
Acked-by: Bruce Richardson <redacted>
Applied, thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help