Re: [PATCH v9 2/2] config: enable vhost numa awareness by default
From: Hemant Agrawal <hidden>
Date: 2017-06-29 05:31:32
On 6/27/2017 3:54 PM, Ilya Maximets wrote:
quoted hunk ↗ jump to hunk
It is safe to enable LIBRTE_VHOST_NUMA by default for all configurations where libnuma is already a default dependency. DPDK_DEP_NUMA not needed anymore. Signed-off-by: Ilya Maximets <redacted> --- config/common_linuxapp | 1 + config/defconfig_arm-armv7a-linuxapp-gcc | 1 + config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 + devtools/test-build.sh | 4 ---- 4 files changed, 3 insertions(+), 4 deletions(-)diff --git a/config/common_linuxapp b/config/common_linuxapp index 64bef87..74c7d64 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp@@ -42,6 +42,7 @@ CONFIG_RTE_KNI_KMOD=y CONFIG_RTE_LIBRTE_KNI=y CONFIG_RTE_LIBRTE_PMD_KNI=y CONFIG_RTE_LIBRTE_VHOST=y +CONFIG_RTE_LIBRTE_VHOST_NUMA=y CONFIG_RTE_LIBRTE_PMD_VHOST=y CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y CONFIG_RTE_LIBRTE_PMD_TAP=ydiff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc index e06b1d4..00bc2ab 100644 --- a/config/defconfig_arm-armv7a-linuxapp-gcc +++ b/config/defconfig_arm-armv7a-linuxapp-gcc@@ -49,6 +49,7 @@ CONFIG_RTE_TOOLCHAIN_GCC=y # NUMA is not supported on ARM CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n +CONFIG_RTE_LIBRTE_VHOST_NUMA=n # ARM doesn't have support for vmware TSC map CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=ndiff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc index f78449d..b061fb0 100644 --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc@@ -47,6 +47,7 @@ CONFIG_RTE_PKTMBUF_HEADROOM=256 # Doesn't support NUMA CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y +CONFIG_RTE_LIBRTE_VHOST_NUMA=n # # Compile Support Libraries for DPAA2diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 61bdce7..0dbc04a 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh@@ -41,7 +41,6 @@ default_path=$PATH # - DPDK_DEP_ISAL_CRYPTO (y/[n]) # - DPDK_DEP_LDFLAGS # - DPDK_DEP_MOFED (y/[n]) -# - DPDK_DEP_NUMA (y/[n]) # - DPDK_DEP_PCAP (y/[n]) # - DPDK_DEP_SSL (y/[n]) # - DPDK_DEP_SZE (y/[n])@@ -124,7 +123,6 @@ reset_env () unset DPDK_DEP_ISAL_CRYPTO unset DPDK_DEP_LDFLAGS unset DPDK_DEP_MOFED - unset DPDK_DEP_NUMA unset DPDK_DEP_PCAP unset DPDK_DEP_SSL unset DPDK_DEP_SZE@@ -163,8 +161,6 @@ config () # <directory> <target> <options> sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config ) # Automatic configuration - test "$DPDK_DEP_NUMA" != y || \ - sed -ri 's,(NUMA=)n,\1y,' $1/.config sed -ri 's,(LIBRTE_IEEE1588=)n,\1y,' $1/.config sed -ri 's,(BYPASS=)n,\1y,' $1/.config test "$DPDK_DEP_ARCHIVE" != y || \
Acked-by: Hemant Agrawal <redacted>