[PATCH v3 21/22] vhost: do not destroy device on repeat mem table message
From: Yuanhan Liu <hidden>
Date: 2017-03-28 12:48:32
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
From: Yuanhan Liu <hidden>
Date: 2017-03-28 12:48:32
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
It doesn't make any sense to invoke destroy_device() callback at while handling SET_MEM_TABLE message.
From the vhost-user spec, it's the GET_VRING_BASE message indicates
the end of a vhost device: the destroy_device() should be invoked from there (luckily, we already did that). Signed-off-by: Yuanhan Liu <redacted> --- lib/librte_vhost/vhost_user.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 40cc973..079c55e 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c@@ -496,12 +496,6 @@ uint32_t i; int fd; - /* Remove from the data plane. */ - if (dev->flags & VIRTIO_DEV_RUNNING) { - dev->flags &= ~VIRTIO_DEV_RUNNING; - dev->notify_ops->destroy_device(dev->vid); - } - if (dev->mem) { free_mem_region(dev); rte_free(dev->mem);
--
1.9.0