Hi Thomas,

On 27/3/2017 2:02 PM, Thomas Monjalon wrote:

2017-03-20 10:08, David Hunt:

quoted

Also bumped up the ABI version number in the Makefile

It would be good to explain the intent of versioning here.

quoted

Signed-off-by: David Hunt <redacted>
Acked-by: Bruce Richardson <redacted>
---
  lib/librte_distributor/Makefile                    |  2 +-
  lib/librte_distributor/rte_distributor.c           | 57 +++++++++++---
  lib/librte_distributor/rte_distributor_v1705.h     | 89 ++++++++++++++++++++++
  lib/librte_distributor/rte_distributor_v20.c       | 10 +++
  lib/librte_distributor/rte_distributor_version.map | 14 ++++
  5 files changed, 162 insertions(+), 10 deletions(-)
  create mode 100644 lib/librte_distributor/rte_distributor_v1705.h

diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile
index 2b28eff..2f05cf3 100644
--- a/lib/librte_distributor/Makefile
+++ b/lib/librte_distributor/Makefile

@@ -39,7 +39,7 @@ CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
  
  EXPORT_MAP := rte_distributor_version.map
  
-LIBABIVER := 1
+LIBABIVER := 2

Why keeping ABI compat if you bump ABIVER?

I guess you do not really want to bump now.

You are correct. The symbol versioning will ensure old binaries will 
work without the bump in LIBABIVER.
Please do not apply this line.

Thanks,
Dave.