Thread (202 messages) 202 messages, 7 authors, 2017-03-29

Re: [PATCH v7 07/17] lib: apply symbol versioning to distibutor lib

From: Hunt, David <hidden>
Date: 2017-02-21 11:50:10

On 21/2/2017 3:17 AM, David Hunt wrote:
Note: LIBABIVER is also bumped up in the Makefile

Signed-off-by: David Hunt <redacted>
---
  lib/librte_distributor/rte_distributor.c           | 10 +++++++++-
  lib/librte_distributor/rte_distributor_v20.c       | 10 ++++++++++
  lib/librte_distributor/rte_distributor_version.map | 14 ++++++++++++++
  3 files changed, 33 insertions(+), 1 deletion(-)
--snip--

The following is generated by checkpatch for this patch:

ERROR:SPACING: space required after that ',' (ctx:VxO)
#70: FILE: lib/librte_distributor/rte_distributor.c:105:
+BIND_DEFAULT_SYMBOL(rte_distributor_request_pkt,, 17.05);
                                                 ^

However, I also tried with a space:

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#26: FILE: lib/librte_distributor/rte_distributor.c:105:
+BIND_DEFAULT_SYMBOL(rte_distributor_request_pkt, , 17.05);
                                                   ^
So in either case it seems it's not possible to make checkpatch happy.


Rgds,
Dave.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help