Re: [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd
From: Ravi Kerur <hidden>
Date: 2017-03-01 15:29:24
Hi Konstantin, Thank you for the review. RSS hash value changes could be due to merge, I didn't make that change. I will go through the changes and fix it in 'v2' patch along with RFC removed and checkpatch fix. Thanks. On Tue, Feb 28, 2017 at 2:36 AM, Ananyev, Konstantin < konstantin.ananyev@intel.com> wrote:
quoted hunk ↗ jump to hunk
Hi Ravi,quoted
Thanks to Konstantin and Bruce on first internal review comments. This patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file read options to build LPM and EM tables.Thanks for the patch, I think it is really useful one. Can I suggest you re-submit it as non-RFC now, as we are in 17.05 window already? About the patch itself, one question I forgot to ask you before:+++ b/examples/l3fwd/main.c@@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf = { .rx_adv_conf = { .rss_conf = { .rss_key = NULL, - .rss_hf = ETH_RSS_IP, + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | + ETH_RSS_TCP | ETH_RSS_SCTP, + }, },Why it is necessary to change RSS hash input values? As another nit - there are few checkpatch warnings, that probably need to be addressed. Apart from that looks good to me. Thanks Konstantin