Thread (8 messages) 8 messages, 2 authors, 2017-03-04

Re: [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

From: Ananyev, Konstantin <hidden>
Date: 2017-02-28 10:36:20

Hi Ravi,
Thanks to Konstantin and Bruce on first internal review comments. This
patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file
read options to build LPM and EM tables.

Thanks for the patch, I think it is really useful one.
Can I suggest you re-submit it as non-RFC now, as we are in 17.05 window already?
About the patch itself, one question I forgot to ask you before:
+++ b/examples/l3fwd/main.c
@@ -161,7 +163,9 @@  static struct rte_eth_conf port_conf = {
 	.rx_adv_conf = {
 		.rss_conf = {
 			.rss_key = NULL,
-			.rss_hf = ETH_RSS_IP,
+			.rss_hf = ETH_RSS_IP | ETH_RSS_UDP |
+				ETH_RSS_TCP | ETH_RSS_SCTP,
+
 		},
 	},

Why it is necessary to change RSS hash input values?

As another nit - there are few checkpatch warnings, that probably need
to be addressed.
Apart from that looks good to me.
Thanks
Konstantin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help