Re: [PATCH v2 11/15] net/avp: packet receive functions

On Wed, 01 Mar 2017 15:14:57 +0100
Thomas Monjalon [off-list ref] wrote:

2017-03-01 13:23, Legacy, Allain:

quoted

quoted

-----Original Message-----
From: Bruce Richardson [mailto:bruce.richardson@intel.com]
In my experience, checkpatch ignores long lines that are due to error
messages. Perhaps you need to put the error message on a separate line,
if other things before the message are of significant size.  

I have gone through the entire patchset and reverted my previous changes to reduce line length on any occurrences of debug log strings.   I kept the error message on the first line and all input variables on subsequent lines (and no longer than 80).   checkpatches.sh flags most of them as warnings, but since unbroken strings seems more important I will submit my next patchset version (v3) like this. 

WARNING:LONG_LINE_STRING: line over 80 characters
#120: FILE: drivers/net/avp/avp_ethdev.c:236:
+			PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n",
  

There is maybe something to fix in the checkpatches.sh options.
Please could you look at SPLIT_STRING and LONG_LINE_STRING?

In checkpatch source there is a regex to identify logging functions and special exceptions for
long lines etc. But the logging functions are for kernel (printk etc), not DPDK logging functions
so the messages are incorrect.

Maybe there is some way to extend checkpatch to handle rte_log?